Skip to content

Commit

Permalink
build(node): drop support for Node v12. Support only NodeJS >= 14.17.x
Browse files Browse the repository at this point in the history
BREAKING CHANGE: Dropped support for Node v12. Minimum supported NodeJS version is now >= 14.17.x.
  • Loading branch information
spotify-kai committed Sep 19, 2021
1 parent d26cc4d commit be04398
Show file tree
Hide file tree
Showing 14 changed files with 38 additions and 32 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/publish-develop.yml
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ jobs:
run: git fetch --depth=1 origin +refs/tags/*:refs/tags/*
- uses: actions/setup-node@v2
with:
node-version: 14
node-version: 14.17
- name: yarn install
run: yarn
- name: yarn build
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/publish-release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ jobs:
run: git fetch --depth=1 origin +refs/tags/*:refs/tags/*
- uses: actions/setup-node@v2
with:
node-version: 14
node-version: 14.17
- name: yarn install
run: yarn
- name: yarn build
Expand Down
44 changes: 25 additions & 19 deletions .github/workflows/publish.yml
Original file line number Diff line number Diff line change
Expand Up @@ -3,29 +3,35 @@ name: Publish
on:
push:
branches:
- master
- master

jobs:
publish:
name: Publish
runs-on: ubuntu-latest

steps:
- uses: actions/checkout@v2
- uses: actions/setup-node@v2
with:
node-version: 14
- name: yarn install
run: yarn
- name: yarn build
run: yarn build
- name: lint
run: yarn lint
- name: test
run: yarn test
- name: release
run: yarn release
env:
NPM_TOKEN: ${{ secrets.NPM_TOKEN }}
GH_TOKEN: ${{ secrets.GH_TOKEN }}
GH_USERNAME: ${{ secrets.GH_USERNAME }}
- uses: actions/checkout@v2
with:
# pulls all commits (needed for lerna / semantic release to correctly version)
fetch-depth: '0'
# pulls all tags (needed for lerna / semantic release to correctly version)
- name: fetch tags
run: git fetch --depth=1 origin +refs/tags/*:refs/tags/*
- uses: actions/setup-node@v2
with:
node-version: 14.17
- name: yarn install
run: yarn
- name: yarn build
run: yarn build
- name: lint
run: yarn lint
- name: test
run: yarn test
- name: release
run: yarn release
env:
NPM_TOKEN: ${{ secrets.NPM_TOKEN }}
GH_TOKEN: ${{ secrets.GH_TOKEN }}
GH_USERNAME: ${{ secrets.GH_USERNAME }}
2 changes: 1 addition & 1 deletion .github/workflows/test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ jobs:

strategy:
matrix:
node-version: [12.x, 14.x]
node-version: [14.17]

steps:
- uses: actions/checkout@v2
Expand Down
2 changes: 1 addition & 1 deletion packages/create-web-scripts-library/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -49,6 +49,6 @@
"access": "public"
},
"engines": {
"node": ">=12.0.0"
"node": ">=14.17.0"
}
}
2 changes: 1 addition & 1 deletion packages/eslint-config-base/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,6 @@
"access": "public"
},
"engines": {
"node": ">=12.0.0"
"node": ">=14.17.0"
}
}
2 changes: 1 addition & 1 deletion packages/eslint-config-react/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,6 @@
"access": "public"
},
"engines": {
"node": ">=12.0.0"
"node": ">=14.17.0"
}
}
2 changes: 1 addition & 1 deletion packages/eslint-config-typescript/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,6 @@
"access": "public"
},
"engines": {
"node": ">=12.0.0"
"node": ">=14.17.0"
}
}
2 changes: 1 addition & 1 deletion packages/eslint-config/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,6 @@
"access": "public"
},
"engines": {
"node": ">=12.0.0"
"node": ">=14.17.0"
}
}
2 changes: 1 addition & 1 deletion packages/eslint-plugin/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -50,6 +50,6 @@
"access": "public"
},
"engines": {
"node": ">=12.0.0"
"node": ">=14.17.0"
}
}
2 changes: 1 addition & 1 deletion packages/prettier-config/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,6 @@
"access": "public"
},
"engines": {
"node": ">=12.0.0"
"node": ">=14.17.0"
}
}
2 changes: 1 addition & 1 deletion packages/tsconfig/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,6 @@
"access": "public"
},
"engines": {
"node": ">=12.0.0"
"node": ">=14.17.0"
}
}
2 changes: 1 addition & 1 deletion packages/web-scripts-utils/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,6 @@
"access": "public"
},
"engines": {
"node": ">=12.0.0"
"node": ">=14.17.0"
}
}
2 changes: 1 addition & 1 deletion packages/web-scripts/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -66,6 +66,6 @@
"access": "public"
},
"engines": {
"node": ">=12.0.0"
"node": ">=14.17.0"
}
}

0 comments on commit be04398

Please sign in to comment.