Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[eslint-config-typescript] add support for eslint-spaced-comments #117

Closed
ODEit opened this issue Jan 6, 2020 · 0 comments · Fixed by #153
Closed

[eslint-config-typescript] add support for eslint-spaced-comments #117

ODEit opened this issue Jan 6, 2020 · 0 comments · Fixed by #153
Labels
bug Something isn't working

Comments

@ODEit
Copy link
Collaborator

ODEit commented Jan 6, 2020

see this issue typescript-eslint/typescript-eslint#600

for example

/* eslint spaced-comment: ["error", "always", { "markers": ["/"] }] */

/// <reference types="next" />
/// <reference types="next/types/global" />

...
@fastfrwrd fastfrwrd added the bug Something isn't working label Jan 21, 2020
fastfrwrd pushed a commit that referenced this issue Jan 21, 2020
fix(eslint-config-base): allow triple slashes
8ee981d 
triple slashes are used in TypeScript declarations. The ESLint rule spaced-comment can interfere
with them, especially when using `--fix`.

fix #117
@fastfrwrd fastfrwrd mentioned this issue Jan 21, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(eslint-config-base): allow triple slashes spotify/web-scripts
2 participants
@fastfrwrd @ODEit