Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(eslint-config-react): Add static-variables to react/sort-comp #70

Merged
merged 1 commit into from Oct 24, 2019

Commits on Oct 24, 2019

  1. fix(eslint-config-react): Add static-variables to react/sort-comp

    `eslint-plugin-react` was updated (jsx-eslint/eslint-plugin-react#2408)
    to support a new `static-variables` option to `react/sort-comp`. With this
    change, our linting started breaking. After some investigation, it turns out
    that `statics` seems to refer to some old `React.createClass` option, so
    static variables actually fell into the check for `static-methods`. Now that is
    fixed and `static-methods` only check for methods and `static-variables` only
    check for variables. So it doesn't seem like a breaking change, but we seem to
    have misused the options a bit.
    
    By only adding `static-variables` to our list we should still support older
    apps using `React.createClass` (if any), and everything will work again like
    before.
    koggdal committed Oct 24, 2019
    Configuration menu
    Copy the full SHA
    f0526c0 View commit details
    Browse the repository at this point in the history