Made cache_path and username optional #567
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DJSdev
suggested changes
Aug 30, 2020
spotipy/oauth2.py
Outdated
| token_info["refresh_token"] | ||
| ) | ||
| except IOError: | ||
| pass |
There was a problem hiding this comment.
I know you simply fixed up these try/catch statements. Could we throw in a logger warning similar to line 1026?
Suggested change
| pass | |
| logger.warning("Couldn't read cache at: %s", self.cache_path) |
There was a problem hiding this comment.
I ended up doing something similar locally as a workaround, I like your fix :)
There was a problem hiding this comment.
Thanks, I just released it in 2.15.0
This was referenced Aug 30, 2020
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As suggested here #533 (comment)
The API itself does not require a username but Spotipy was still asking for it in order to know where to store the token.
I think most devs want to get started quickly and will by default only use their main account, so storing that main account token in a cache called
.cacheshould be fine.Apps that specify a username should still work.
Fixes #507, #512, #549