Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed UnboundLocalError / AttributeError #571, #581 #583

Merged
merged 4 commits into from Oct 7, 2020

Conversation

Quizz1Cal
Copy link
Contributor

@Quizz1Cal Quizz1Cal commented Oct 6, 2020

Have also added an integration test to confirm that when max entries is reached, SpotifyException is thrown, and not the unexpected errors noted in issues #571 and #581.

Fixes #571 and #581.

Copy link
Member

@stephanebruckert stephanebruckert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good, I added a suggestion for the test

CHANGELOG.md Outdated Show resolved Hide resolved
tests/integration/test_non_user_endpoints.py Outdated Show resolved Hide resolved
tests/integration/test_non_user_endpoints.py Outdated Show resolved Hide resolved
@stephanebruckert stephanebruckert linked an issue Oct 6, 2020 that may be closed by this pull request
Quizz1Cal and others added 2 commits October 7, 2020 11:13
@Quizz1Cal
Copy link
Contributor Author

Changes agreed with and committed.

@stephanebruckert
Copy link
Member

Amazing, thanks for finding and fixing that one! 👌

@stephanebruckert stephanebruckert merged commit 4bb4259 into spotipy-dev:master Oct 7, 2020
@Quizz1Cal Quizz1Cal deleted the fix581 branch October 10, 2020 01:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants