Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PHP 7 #96

Closed
dterweij opened this issue Oct 3, 2015 · 8 comments
Closed

PHP 7 #96

dterweij opened this issue Oct 3, 2015 · 8 comments

Comments

@dterweij
Copy link

dterweij commented Oct 3, 2015

I think that spotweb needs to be refactored for PHP 7. Tho it works, but shows a lot warnings.
My old server died so i installed everything fresh and newer :)

@Wally73
Copy link
Contributor

Wally73 commented Oct 3, 2015

php 7??? last stable one is 5.6.14

On Sat, Oct 3, 2015 at 1:07 PM, Danny Terweij notifications@github.com
wrote:

I think that spotweb needs to be refactored for PHP 7. Tho it works, but
shows a lot warnings.
My old server died so i installed everything fresh and newer :)


Reply to this email directly or view it on GitHub
#96.

@Sweepr
Copy link
Collaborator

Sweepr commented Oct 4, 2015

PHP 7 is in RC stage, the release candidate features bug fixes and stability improvements, but it cannot be used in production yet

@Sweepr Sweepr closed this as completed Oct 4, 2015
@futurevision
Copy link

PHP 7 is planned to arrive next month already. I'm not sure why this is closed since this can become an issue for a lot of users real fast.

@Sweepr
Copy link
Collaborator

Sweepr commented Oct 5, 2015

It's not released officially, so no need to keep this open, will reopen when needed.

As it seems to run fine in php 7, but show warnings, could you maybe post the warnings so we can see whats happening?

@denniskrol
Copy link

PHP Deprecated:  Methods with the same name as their class will not be constructors in a future version of PHP; Net_NNTP_Client has a deprecated constructor in \spotweb\NNTP\Client.php on line 87
PHP Deprecated:  Methods with the same name as their class will not be constructors in a future version of PHP; Net_NNTP_Protocol_Client has a deprecated constructor in \spotweb\NNTP\Protocol\Client.php on line 131
PHP Deprecated:  Methods with the same name as their class will not be constructors in a future version of PHP; Crypt_Hash has a deprecated constructor in \spotweb\vendor\phpseclib\Crypt\Hash.php on line 85
PHP Deprecated:  Methods with the same name as their class will not be constructors in a future version of PHP; Crypt_RSA has a deprecated constructor in \spotweb\vendor\phpseclib\Crypt\RSA.php on line 251
PHP Deprecated:  Methods with the same name as their class will not be constructors in a future version of PHP; Math_BigInteger has a deprecated constructor in \spotweb\vendor\phpseclib\Math\BigInteger.php on line 193

It works, but it's gonna break some day.

@blaatpraat
Copy link

In the meantime PHP 7 is released, and already has received an update.

I think you should reopen this bug...

@mesa57
Copy link
Collaborator

mesa57 commented Jan 3, 2016

This is not a bug, but a feature request. Spotweb was not designed for php 7.
And of cause you can create a branche and update the code accordingly.
[edit]
I see that there is already a pull request for this
[/edit]

@CptChaos
Copy link

Mesa is referring to pull request #104
Where actually not much happened.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

8 participants