Turn off "hidden-v3" (ampproject#9026)

spotxchange · May 3, 2017 · d57415c · d57415c
1 parent 94311c2
commit d57415c
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 4 deletions.
diff --git a/extensions/amp-analytics/0.1/instrumentation.js b/extensions/amp-analytics/0.1/instrumentation.js
@@ -571,8 +571,7 @@ export class AnalyticsGroup {
   addTrigger(config, handler) {
     let eventType = dev().assertString(config['on']);
     // TODO(dvoytenko, #8121): Cleanup visibility-v3 experiment.
-    if ((eventType == 'visible' || eventType == 'hidden')
-        && this.visibilityV3_) {
+    if ((eventType == 'visible') && this.visibilityV3_) {
       eventType += '-v3';
     }
     let trackerProfile = EVENT_TRACKERS[eventType];

diff --git a/extensions/amp-analytics/0.1/test/test-instrumentation.js b/extensions/amp-analytics/0.1/test/test-instrumentation.js
@@ -235,10 +235,10 @@ describes.realWin('InstrumentationService', {amp: 1}, env => {
           analyticsElement, 'visible-v3', config, handler);
     });
 
-    it('should add "visible-v3" trigger for hidden', () => {
+    it('should add "visible-v3" trigger for hidden-v3', () => {
       toggleExperiment(win, 'visibility-v3', true);
       group = service.createAnalyticsGroup(analyticsElement);
-      const config = {on: 'hidden'};
+      const config = {on: 'hidden-v3'};
       const getTrackerSpy = sandbox.spy(root, 'getTracker');
       group.addTrigger(config, () => {});
       expect(getTrackerSpy).to.be.calledWith('visible-v3');