Skip to content

Gendarme.Rules.BadPractice.UseFileOpenOnlyWithFileAccessRule(2.10)

Sebastien Pouliot edited this page Jan 22, 2011 · 2 revisions

UseFileOpenOnlyWithFileAccessRule

Assembly: Gendarme.Rules.BadPractice
Version: 2.10

Description

This rule checks that when file open method is called with FileMode parameter it is also called with FileAccess (or FileSystemRights) parameter. It is needed because default behaviour of file open methods when they are called only with FileMode is to require read-write access while it is commonly expected that they will require only read access.

Examples

Bad example:

public void OpenFile ()
{
    FileStream f = File.Open ("Filename.ext", FileMode.Open);
}

Good example:

public void OpenFile ()
{
    FileStream f = File.Open ("Filename.ext", FileMode.Open, FileAccess.Read);
}
Clone this wiki locally