Skip to content

Gendarme.Rules.Naming.AvoidRedundancyInMethodNameRule(git)

Sebastien Pouliot edited this page Mar 2, 2011 · 1 revision

AvoidRedundancyInMethodNameRule

Assembly: Gendarme.Rules.Naming
Version: git

Description

This rule will fire if a method name embeds the type name of its first parameter. Usually, removing that type name makes the API less verbose, easier to learn, and more future-proof.

Examples

Bad example:

class PostOffice {
    public void SendLetter (Letter letter) {
    }
    public void SendPackage (Package package) {
    }
}

Good example:

class PostOffice {
    public void Send (Letter letter) {
    }
    public void Send (Package package) {
    }
}

Bad example:

class PostOffice {
    public static bool IsPackageValid (Package package) {
        return package.HasAddress && package.HasStamp;
    }
}

Good example:

class Package {
    public bool IsValid {
        get {
            return HasAddress && HasStamp;
        }
    }
}

Source code

You can browse the latest source code of this rule on github.com

Clone this wiki locally