Merge pull request #216 from kohlerdominik/fix-issue#214

Test ini-parameter for truthy instead of string
sprain · Feb 21, 2023 · 75b45a0 · 75b45a0
2 parents acf35b8 + 00f10a2
commit 75b45a0
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/src/PaymentPart/Output/FpdfOutput/FpdfOutput.php b/src/PaymentPart/Output/FpdfOutput/FpdfOutput.php
@@ -100,7 +100,7 @@ private function addSwissQrCodeImage(): void
         $yPosQrCode = 209.5 + $this->offsetY;
         $xPosQrCode = 67 + $this->offsetX;
 
-        if ("1" === ini_get('allow_url_fopen')) {
+        if ((bool)ini_get('allow_url_fopen')) {
             $this->fpdf->Image(
                 $qrCode->getDataUri($this->getQrCodeImageFormat()),
                 $xPosQrCode,

diff --git a/tests/PaymentPart/Output/FpdfOutput/FpdfOutputTest.php b/tests/PaymentPart/Output/FpdfOutput/FpdfOutputTest.php
@@ -80,7 +80,7 @@ public function testItThrowsSvgNotSupportedException(): void
 
     public function testItThrowsUnsupportedEnvironmentException(): void
     {
-        if (ini_get('allow_url_fopen') === "1") {
+        if ((bool)ini_get('allow_url_fopen')) {
             $this->markTestSkipped("This test only works in hardened environment.");
         }