Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test ini-parameter for truthy instead of string #216

Merged
merged 1 commit into from
Feb 21, 2023

Conversation

kohlerdominik
Copy link
Contributor

@kohlerdominik kohlerdominik commented Feb 20, 2023

Acording to the docs, ini_get should return "", "0" or "1" for boolean config

Note: When querying boolean values A boolean ini value of off will be returned as an empty string or "0" while a boolean ini value of on will be returned as "1". The function can also return the literal string of INI value.

However, according to #214 there seem to be environments, that do not follow this. So it's probably best to test for truthy.

@sprain
Copy link
Owner

sprain commented Feb 21, 2023

🙏

@sprain sprain merged commit 75b45a0 into sprain:master Feb 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants