Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preload using with_translations #92

Merged
merged 5 commits into from
Apr 6, 2022

Commits on Aug 25, 2021

  1. Removed Translation Preloading

    Testing to see what is causing issues with the latest version of spree's product searcher in the taxon controller.
    npflood committed Aug 25, 2021
    Configuration menu
    Copy the full SHA
    114851d View commit details
    Browse the repository at this point in the history

Commits on Aug 27, 2021

  1. preload using with_translations

    * Use the Globalize with_translations scope to preload translations
    
    SpreeGlobalize::Translatable now uses the `with_translations` class method to set `spree_base_scopes` instead of the previous `.includes(:translations).references(:translations)`
    
    This fixes an issue where Spree v6.3.0 built queries that could not be executed due to the additional tables that `.includes(:translations).references(:translations)` creates while still avoiding n+1 queries.
    
    * Changes to Gemfile and Test Suite to support Spree v6.3.0
    npflood committed Aug 27, 2021
    Configuration menu
    Copy the full SHA
    923b3b4 View commit details
    Browse the repository at this point in the history
  2. Update spree_master.gemfile

    npflood committed Aug 27, 2021
    Configuration menu
    Copy the full SHA
    34c1375 View commit details
    Browse the repository at this point in the history
  3. Update spree_4_2.gemfile

    Reflect Github's change to main from master branch.
    npflood committed Aug 27, 2021
    Configuration menu
    Copy the full SHA
    a94e34f View commit details
    Browse the repository at this point in the history
  4. Update spree_master.gemfile

    Reflect Github's change from master to main
    npflood committed Aug 27, 2021
    Configuration menu
    Copy the full SHA
    b6a84a5 View commit details
    Browse the repository at this point in the history