Preload using with_translations #92
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Testing to see what is causing issues with the latest version of spree's product searcher in the taxon controller.
* Use the Globalize with_translations scope to preload translations SpreeGlobalize::Translatable now uses the `with_translations` class method to set `spree_base_scopes` instead of the previous `.includes(:translations).references(:translations)` This fixes an issue where Spree v6.3.0 built queries that could not be executed due to the additional tables that `.includes(:translations).references(:translations)` creates while still avoiding n+1 queries. * Changes to Gemfile and Test Suite to support Spree v6.3.0
Reflect Github's change to main from master branch.
Reflect Github's change from master to main
|
This fixes an issue with a currently released version of Spree. Can someone review the changes and either merge this branch or indicate that the underlying issue has been resolved in another way? |
|
is this going to be accept? |
|
I can also confirm this bug and the fix works, should be merged... |
damianlegawiec
approved these changes
Apr 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #90
Navigating to a taxon view in spree_frontend (any URL like /t/taxon_name) where products should be returned raised PG::GroupingError: ERROR: column "spree_product_translations.id" must appear in the GROUP BY clause or be used in an aggregate function
Removing the .includes(:translations).references(:translations) from the spree_base_scopes method in SpreeGlobalize::Translatable allows the query to succeed, but causes n+1 queries.
Adding .with_translations to the spree_base_scopes method in SpreeGlobalize::Translatable allows the query to succeed, without n+1 queries.