Don't include ellipsis in truncated digest output #183
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iNecas
force-pushed
the
ellipsis-fix
branch
2 times, most recently
from
57ebb76
to
2c26e02
Compare
|
@bbonislawski @damianlegawiec as #180 was released, in contains an issue with '...' being included in the hashes. Mind merging this fix and releasing a new version? The latest release is broken when trying to use sha1 hashing mechanism. Thanks |
|
Just in case you would have a chance to have a look @bbonislawski @damianlegawiec. This is still an issue for us |
|
@iNecas Can you rebase against current master branch? |
Using truncate to limit the length of the digest has the unwanted side effect of adding an ellipsis when the input is longer than the limit. Also don't instantiate a new object for every digest. Inspired by rails/rails@b9e7c67
iNecas
force-pushed
the
ellipsis-fix
branch
from
2c26e02
to
2c04d4d
Compare
|
Rebased |
|
Thanks for merge, Any chance to get a new release with this change? |
|
@iNecas will do it today - sorry for the long delay - we're polishing another Spree release and that takes some time as you can imagine :) |
|
@iNecas |
|
Awesome. Thanks @damianlegawiec! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using truncate to limit the length of the digest has the unwanted side
effect of adding an ellipsis when the input is longer than the limit.
Also don't instantiate a new object for every digest.
Inspired by
rails/rails@b9e7c67