respond_override for OrdersController#populate breaks OrdersController#update

[laurens]

I want to use a respond_override for displaying a flash message, after an item has been added to the cart.
So I added an orders_controller_decorator.rb with the following line:

respond_override :populate => { :html => { :success => lambda { redirect_to cart_path, :notice => 'item added' } } }

This works, however it breaks the update action. When I update the quantity of an item in the cart, the page gets redirected to the order url instead of going back to the cart.

I am on Spree 1.2, Ruby 1.9.2p290

Tested on a fresh spree install including spree_auth_devise

Server Log: https://gist.github.com/4069200

[radar]

I can confirm this issue exists. Will look into it.

[radar]

I can still verify this issue exists in 2-0-stable and master, but I cannot figure out the code that is required to make this work. Marking this issue as "stalled".

[leiyangyou]

The problem seems to lie in the file core/lib/spree/core/controller_helpers/respond_with.rb

if defined_response = collector.response and 
!Spree::BaseController.spree_responders.keys.include?(self.class.to_s.to_sym)

only checks if a particular controller has a overriding responder, but does not check if the overriding responder defines a handler for the current action, this prevents the default handler of the action from running

it probably needs to be changed into this

if defined_response = collector.response and 
!(Spree::BaseController.spree_responders[self.class.to_s.to_sym].try(:[], action_name.to_sym)

but then again, this implementation does not check if the overriding action handler handles the requested format, and whether it provides a failure clause in the case of a failure etc, so there is probably a better way to do this.

[JDutil]

triage:verified