Override in checkout_flow results session clearing

[abdul-shajin]

I've overrided checkout_flow method and tried the checkout process

checkout_flow do
go_to_state :address
#go_to_state :delivery commented
go_to_state :payment, :if => lambda { |order| order.payment_required? }
go_to_state :confirm, if: ->(order) { order.confirmation_required? }
go_to_state :complete, if: ->(order) {
(order.payment_required? && order.has_unprocessed_payments?) || !order.payment_required?
}
remove_transition from: :delivery, to: :confirm
end

It successfully removes the shipment(delivery process) and when clicks 'Continue' button, redirects to 'No items page' (Empty Cart)

Any kind of bug??

[huoxito]

I can confirm this. The line items are being removed on the CheckoutController#before_payment filter. I'm not sure why.

def before_payment
  packages = @order.shipments.map { |s| s.to_package }
  @differentiator = Spree::Stock::Differentiator.new(@order, packages)
  @differentiator.missing.each do |variant, quantity|
    @order.contents.remove(variant, quantity)
  end
end

Thanks for the report @CodeSavvy

[GeekOnCoffee]

@CodeSavvy is this still an issue after the Pull Request?

[abdul-shajin]

@GeekOnCoffee Infact, I didn't check.since I don't need shipping, I override before_payment method with a blank method (def before_payment;end)

[huoxito]

@GeekOnCoffee I think it is. which PR were you referring to?

[GeekOnCoffee]

@huoxito #2959 is referenced above

[huoxito]

Ah ok, but that one is for a different issue. Guess this one remains then

[radar]

@huoxito Does this fix #3142 and #3284?

[huoxito]

for sure @radar yes