Only run transition callbacks if order state is cart #2959
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Calling order.next_transition.run_callbacks with order in payment state might raise undefined method `run_callbacks' for nil:NilClass And we only need to call that manually when changing from cart to address, fixes spree#2921
|
btw I think 1-3-stable needs this too. |
|
@CodeSavvy The error it tries to fix regards the first order state transition, usually cart -> address, I don't think it's related to the fact you removed the delivery step. Also please tell what it's not working for you exactly. |
|
@huoxito I thought #2966 (comment) this bug is due to this reason..and I've mistaken..sorry for this |
|
@huoxito This patch does not apply cleanly to 1-3-stable. Can you please port over your changes to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Calling order.next_transition.run_callbacks with order in payment state
might raise
undefined method `run_callbacks' for nil:NilClass
And we only need to call that manually when changing from cart to
address, fixes #2921
Please let me know if I missed anything or it breaks the build. I've only run controllers and the checkout feature spec.