Cannot modify payment option on an cancelled order

[Senjai]

Related to #3697

Steps taken to reproduce this issue: (development)

Create an order as a standard user using check as the payment option

Login to the administrative interface.

Manually capture the payment via clicking balance due for the appropriate order to change the payment status to PAID.

Click the order number to edit the order.

Click Cancel Order and return to the screen. Cancelling the order does not change the payment state.

Click the PAID payment state to try to edit it, or void it and you will be redirected to editing the customers information, and thusly cannot change the state.

Not sure if this is intended behavior.

Gemfile: Standard except for spree:

gem 'spree', '2.0.4'
gem 'spree_gateway', :git => 'https://github.com/spree/spree_gateway.git', :branch => '2-0-stable'
gem 'spree_auth_devise', :git => 'https://github.com/spree/spree_auth_devise.git', :branch => '2-0-stable'

[radar]

Do you see the same problem on 2-0-stable? Seems familiar to #3336.

[Senjai]

@radar
Confirmed on 2-0 stable.

gem 'spree', :git => 'https://github.com/spree/spree.git', :branch => '2-0-stable'
gem 'spree_gateway', :git => 'https://github.com/spree/spree_gateway.git', :branch => '2-0-stable'
gem 'spree_auth_devise', :git => 'https://github.com/spree/spree_auth_devise.git', :branch => '2-0-stable'

Works fine on 2-1-stable so I guess there is an issue that has to be looked into..

gem 'spree', :git => 'https://github.com/spree/spree.git', :branch => '2-1-stable'
gem 'spree_gateway', :git => 'https://github.com/spree/spree_gateway.git', :branch => '2-1-stable'
gem 'spree_auth_devise', :git => 'https://github.com/spree/spree_auth_devise.git', :branch => '2-1-stable'

[radar]

I've added a fix to this to my master, 2-1-stable and 2-0-stable branches. It was really simple 😄