Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fresh 1-3-4 store boots user to address when payment fails. #4117

Closed
brchristian opened this issue Dec 14, 2013 · 2 comments
Closed

Fresh 1-3-4 store boots user to address when payment fails. #4117

brchristian opened this issue Dec 14, 2013 · 2 comments

Comments

@brchristian
Copy link
Contributor

I've been experimenting with the checkout flow on a blank, fresh 1-3-stable install.

I go to check out with random credit card numbers, e.g., 4242424242424242, and when I hit the confirm button, I am punted back to the 1. Address step. There is no error message. My items are still in my cart. The backend shows a FAILED status for the Credit Card payment.

I'm imagining that the desired behavior would instead be to put me on the payment step and have a message about payment failure?

@radar
Copy link
Contributor

radar commented Dec 16, 2013

I am able to reproduce this issue. The issue here is that you're using an invalid credit card number for the bogus gateway. Here are the valid CC numbers to use with this gateway: https://github.com/spree/spree/blob/1-3-stable/core/app/models/spree/gateway/bogus.rb#L3-L9

Using an invalid CC number with the Stripe gateway does not cause this problem. On 2-1-stable, while it still redirects to the address state (which I would say itself is a bug), it at least shows an error there. I will see if I can fix the redirection issue now.

@radar
Copy link
Contributor

radar commented Dec 17, 2013

I have added a fix for this to 2-0-stable, 2-1-stable and master. I will not add a fix for this to 1-3-stable as it changes existing behaviour, which is a violation of our Release Policy.

radar added a commit that referenced this issue Dec 17, 2013
radar added a commit that referenced this issue Dec 17, 2013
This is now necessary to reach the confirm step, due to #4117
radar added a commit that referenced this issue Dec 17, 2013
radar added a commit that referenced this issue Dec 17, 2013
This is now necessary to reach the confirm step, due to #4117
@radar radar closed this as completed in c26b7f6 Dec 17, 2013
radar added a commit that referenced this issue Dec 17, 2013
This is now necessary to reach the confirm step, due to #4117
radar added a commit to spree/spree_auth_devise that referenced this issue Jan 20, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants