Extra order is created after checkout is complete

[ghost]

Version: 2-0-stable
Observed behavior: An extra new order is created after customers complete checkout process

Repro Steps:

1. add a product to cart
2. register new account
3. walk through the checkout process and complete current order

Possible cause:
Once an order is complete, the session[:order_id] is set to nil. Before OrdersController#Show runs, the before filter set_current_order creates an extra order.

@radar @huoxito Can you take a look?

[huoxito]

I think I have noticed it before too but it never really bothered me. I believe all pages or at least most of the pages within frontend will create an order for the user. Guess we only have to avoid creating new orders on the orders_controller/show action.

[ghost]

I think it's important to only create an order after a user adds a product to cart. Reason is that when you look at the conversion rate or performance of the site, whether an visitor actually created an order is a pretty important metric.

[huoxito]

Yeah makes sense. Will take a look

[ghost]

thx, man