Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Order JSON contains duplicate product information in manifest #4498

Closed
radar opened this issue Mar 27, 2014 · 1 comment
Closed

Order JSON contains duplicate product information in manifest #4498

radar opened this issue Mar 27, 2014 · 1 comment

Comments

@radar
Copy link
Contributor

radar commented Mar 27, 2014

Check out this response: https://gist.github.com/radar/9797853

In the manifest for the shipment, I can see the variant information being returned. This exact same information is returned in the line items response. I don't see any particular reason to have this huge block of information repeated here, and so we should restrict it to probably just the line item's id.

@radar
Copy link
Contributor Author

radar commented Mar 27, 2014

I've got a fix for this on my master branch. It shouldn't be applied to 2-2-stable because it will break
backwards compatibility.

@radar radar closed this as completed in 878801f Apr 28, 2014
yurifrl pushed a commit to azclick/spree that referenced this issue Apr 8, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant