[SD-824] Corrects color presentation in admin panel #10012
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Manage this branch in SquashTest this branch here: https://spark-solutionssd-824-change-c-078lr.squash.io |
PSzyszkaSpark
changed the title
…ebar_extensions.js
pmilewski
approved these changes
Mar 11, 2020
| @@ -8,3 +8,10 @@ Handlebars.registerHelper('t', function (key) { | |||
| Handlebars.registerHelper('edit_product_url', function (productId) { | |||
| return Spree.routes.edit_product(productId) | |||
| }) | |||
| Handlebars.registerHelper('name_or_presentation', function (optionTypePresentation, optionValue) { | |||
| if (optionTypePresentation === 'Color') { | |||
There was a problem hiding this comment.
Suggested change
| if (optionTypePresentation === 'Color') { | |
| if (optionTypePresentation === 'Color') { |
let's compare name, not presentation if possible
damianlegawiec
approved these changes
Mar 11, 2020
damianlegawiec
pushed a commit
that referenced
this pull request
Mar 11, 2020
* Corrects color presentation in admin panel * Corrects handlebar_extensions.js * Corrects color display in variant form and removes upparcase in handlebar_extensions.js * Changes checks from option type presentation to name
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes https://spark-solutions.atlassian.net/browse/SD-824