feat: product finder filter[taxons] by permalink #10059
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Manage this branch in SquashTest this branch here: https://afortyproducts-finder-filter-t-zfqao.squash.io |
|
Ok all set now except for those 3 code climate issues that I'm not really sure what to do about. Happy to oblige if you have any suggestions. |
damianlegawiec
requested changes
Apr 1, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I work a lot with the API in a custom web environments and I found it a pain working with taxon permalinks and fetching products. I need to fetch the taxon first before I can get products for a permalink since the product search API only accepts taxon ID’s.
This allows for permalinks to be passed into the talons filer like so:
/products?filter[taxons]=1,2,men,men/tshirts