Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds The Ability To Show / Not Show Specific Product Properties #10163

Merged
merged 4 commits into from
May 14, 2020
Merged

Adds The Ability To Show / Not Show Specific Product Properties #10163

merged 4 commits into from
May 14, 2020

Conversation

MatthewKennedy
Copy link
Contributor

@MatthewKennedy MatthewKennedy commented May 13, 2020

This PR adds a simple checkbox to the product properties, allowing the Admin to decide what product properties should be displayed on the storefront.

Gives Product Properties power to be used in extensions for passing specific product properties as data in JSON, XML formats, information that you wouldn't otherwise want to be displayed on the product page.

Screenshot 2020-05-13 at 17 32 13

Screenshot 2020-05-13 at 17 32 02

@squash-labs
Copy link

squash-labs bot commented May 13, 2020

Manage this branch in Squash

Test this branch here: https://matthewkennedyshow-properties-janh1.squash.io

Copy link
Member

@damianlegawiec damianlegawiec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! This seems well reasoned

MatthewKennedy and others added 2 commits May 13, 2020 18:34
…uct_properties.rb

Co-authored-by: Damian Legawiec <damian@sparksolutions.co>
Co-authored-by: Damian Legawiec <damian@sparksolutions.co>
@damianlegawiec
Copy link
Member

@MatthewKennedy could you add some test for this feature? Thank you!

@MatthewKennedy
Copy link
Contributor Author

MatthewKennedy commented May 14, 2020

@damianlegawiec Sure, I will do that this afternoon.

@damianlegawiec damianlegawiec merged commit f6a37a2 into spree:master May 14, 2020
@MatthewKennedy MatthewKennedy deleted the show-properties branch July 14, 2020 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants