[SDP-343] Query fix for admin products list search by name #10310
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomurb
approved these changes
Jul 3, 2020
Manage this branch in SquashTest this branch here: https://sdp-343-admin-products-list-fi-g1q5v.squash.io |
aplegatt
commented
Oct 1, 2020
There was a problem hiding this comment.
@aneskap Yes, we do need it. Actually, all tests are passing, the error seems to be about not enough tests but the method I changed is already tested here: https://github.com/spree/spree/blob/master/core/spec/models/spree/product/scopes_spec.rb#L177.
aplegatt
force-pushed
the
sdp-343-admin-products-list-fix
branch
from
b9118c5
to
f6c3d98
Compare
|
@aplegatt I need an update on it - if this is ready for CR, could you post a request on our channel? or is it WIP still? :) thank you! |
KacperMekarski
approved these changes
Jan 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.