Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Promotions UX #10329

Merged
merged 4 commits into from Jul 8, 2020
Merged

Improve Promotions UX #10329

merged 4 commits into from Jul 8, 2020

Conversation

MatthewKennedy
Copy link
Contributor

@MatthewKennedy MatthewKennedy commented Jul 8, 2020

  • Set layout to use full width for all fields in mobile.
  • Set Select2 multiple choice fields to have same border radius, and height as other input fields, even when empty.
  • Make panels more consistent looking for rules and actions.
  • RULE: 'Order total meets these criteria' now makes more sense on mobile size screens.
  • Add date/time picker to promo start from / expires at.

@squash-labs
Copy link

squash-labs bot commented Jul 8, 2020

Manage this branch in Squash

Test this branch here: https://matthewkennedyfix-promos-54axi.squash.io

@damianlegawiec
Copy link
Member

The Date picker in promotions was type datetime_field, everywhere else it is type text_field, so I changed it to match the others, what is the best field to use?

This change was made via #9450 to enable setting also a time of start/end of promotion as promotions are very time-sensitive :)

@MatthewKennedy
Copy link
Contributor Author

@damianlegawiec Shall I update that date picker to a date/time picker and change the field type back?

@damianlegawiec
Copy link
Member

@MatthewKennedy that would be awesome, please do! :)

@MatthewKennedy
Copy link
Contributor Author

@damianlegawiec - I’ll do that today.

@MatthewKennedy
Copy link
Contributor Author

@damianlegawiec I feel that the javascript for the flatpickr.js date and date/time pickers could be written better.

I'll target that in a dedicated PR.

@damianlegawiec damianlegawiec merged commit db467cf into spree:master Jul 8, 2020
@MatthewKennedy MatthewKennedy deleted the fix-promos branch July 14, 2020 09:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants