New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve Promotions UX #10329
Improve Promotions UX #10329
Conversation
MatthewKennedy
commented
Jul 8, 2020
•
edited
edited
- Set layout to use full width for all fields in mobile.
- Set Select2 multiple choice fields to have same border radius, and height as other input fields, even when empty.
- Make panels more consistent looking for rules and actions.
- RULE: 'Order total meets these criteria' now makes more sense on mobile size screens.
- Add date/time picker to promo start from / expires at.
Manage this branch in SquashTest this branch here: https://matthewkennedyfix-promos-54axi.squash.io |
This change was made via #9450 to enable setting also a time of start/end of promotion as promotions are very time-sensitive :) |
@damianlegawiec Shall I update that date picker to a date/time picker and change the field type back? |
@MatthewKennedy that would be awesome, please do! :) |
@damianlegawiec - I’ll do that today. |
@damianlegawiec I feel that the javascript for the flatpickr.js date and date/time pickers could be written better. I'll target that in a dedicated PR. |