[SD-991] Allow removing of line item added by promo code in cart (fix internal server error possibility) #10597
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Manage this branch in SquashTest this branch here: https://cart-line-item-product-8zarn.squash.io |
aplegatt
force-pushed
the
cart-line-item-product
branch
from
f34154f
to
f283061
Compare
|
@nnande Unfortunately it seems that the only option, with how it works currently, is to remove promotion from the order completely. Deactivating it does not solve the problem as it is being activated again while recalculating the cart. |
aplegatt
commented
Jan 29, 2021
damianlegawiec
requested review from
szymoniwacz
and removed request for
przemosk and
nnande
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.