Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ability to switch between different Locales and Currencies in a single Store #10764

Merged
merged 27 commits into from Feb 15, 2021
Merged

Ability to switch between different Locales and Currencies in a single Store #10764

merged 27 commits into from Feb 15, 2021

Conversation

damianlegawiec
Copy link
Member

@damianlegawiec damianlegawiec commented Feb 5, 2021 •
edited

Screen.Recording.2021-02-12.at.6.56.11.PM.mov

spencerwp added a commit to spencerwp/spree that referenced this pull request Feb 6, 2021
@spencerwp
spree/pull/10764
f29e07f 
add multi-locale support to store
@spencerwp
Copy link

This is great - I'm only seeing one problem where :supported_locales is not a valid parameter of the store_attributes.

spree/core/lib/spree/permitted_attributes.rb -
@@store_attributes += [:supported_locales]

@squash-labs
Copy link

squash-labs bot commented Feb 10, 2021

Manage this branch in Squash

Test this branch here: https://featuresupported-locale-t2bev.squash.io

@damianlegawiec damianlegawiec force-pushed the feature/supported-locale branch 5 times, most recently from 1ca939e to 89c5727 Compare February 11, 2021 16:58
@damianlegawiec damianlegawiec marked this pull request as ready for review February 11, 2021 21:04
@flobby
Copy link
Contributor

flobby commented Feb 12, 2021

Not sure if related but on admin backend when I try to access store translations I receive this error. Might be related to globalize though.

NoMethodError - undefined method `translated_attribute_names' for #Class:0x00007fefa2c5c580:

I tracked it down to admin/translations_controller.rb:10 // something in the index action which is very generic.

(using master on commit 166b543)

@damianlegawiec
Copy link
Member Author

Not sure if related but on admin backend when I try to access store translations I receive this error. Might be related to globalize though.

NoMethodError - undefined method `translated_attribute_names' for #Class:0x00007fefa2c5c580:

I tracked it down to admin/translations_controller.rb:10 // something in the index action which is very generic.

(using master on commit 166b543)

Alongside this PR I'm preparing PRs for Spree Globalize and Spree I18n ( spree-contrib/spree_i18n#876 ) to ease the migration path, hopefully, I can finish all of it today/Monday.

@channainfo
Copy link

@damianlegawiec awesome! thank you

@damianlegawiec damianlegawiec force-pushed the feature/supported-locale branch 2 times, most recently from 39fa2fe to 484e1f1 Compare February 15, 2021 07:13
@damianlegawiec damianlegawiec changed the title Feature/supported locale Ability to switch between different Locales and Currencies in a single Store Feb 15, 2021
@damianlegawiec damianlegawiec added this to the 4.2 milestone Feb 15, 2021
@damianlegawiec damianlegawiec force-pushed the feature/supported-locale branch 3 times, most recently from fc7b16c to 69943cc Compare February 15, 2021 07:43
@damianlegawiec
Copy link
Member Author

This is great - I'm only seeing one problem where :supported_locales is not a valid parameter of the store_attributes.

spree/core/lib/spree/permitted_attributes.rb -
@@store_attributes += [:supported_locales]

Done and done!

Vegann
Vegann approved these changes Feb 15, 2021
View reviewed changes
frontend/app/helpers/spree/store_helper.rb Outdated Show resolved Hide resolved
@damianlegawiec
Expose supported_locales in API v1 and v2
a0e62e1
@damianlegawiec
Bring back Locale controller from Spree I18n
743f8d3 
* adds ability to switch locale within scope of current store
* endpoint to render dropdown with a list supported currencies
* additional tests
@damianlegawiec
Always use upcased version of currency (iso format)
17b48f3
@damianlegawiec
Always sort supported locale/currency alphabetically
95bbe4f
@damianlegawiec
Move Admin::CurrencyHelper to CurrencyHelper
c74b8c2 
To be able to use it in Storefront as well
@damianlegawiec
Always use current_currency
436e6ce 
`params[:currency]` can pass not supported currency in current store.
@damianlegawiec
Tests for Store Helper
f188158
@damianlegawiec
Added StoreHelper#should_render_store_chooser?
4feeef3
@damianlegawiec
Make Store Selected hidden by default
4b80175 
Most people will use single store with multiple currencies / locales
@damianlegawiec
Added missing LocaleHelper specs
db27496
@damianlegawiec
Added LocaleHelper#should_render_locale_dropdown?
79c8e88
@damianlegawiec
Added CurencyHelper#should_render_currency_dropdown?
fb9c210
@damianlegawiec
Added NavigationHelper#should_render_internationalization_dropdown?
230ed11
@damianlegawiec
Add UI for switching Locale / Currency in a single Store
26148bf 
This is compatible with Spree I18n / Spree Multi Currency behaviour and is best suited for single store installations that want one store on a single domain with multiple currencies / locales
@damianlegawiec
Use guard clause for scenarios where current_store is not defined
f5e3dc1 
Fallback to `Spree::Config[:currency]` as a last resort
@damianlegawiec
Fixed Store Configuration spec
393051f
@damianlegawiec
Fix API v2 spec for not supported currencies
16c14b9
@damianlegawiec
Update 4.2 release notes
a5ccbe3
@damianlegawiec
Added FrontendHelper#country_flag_icon
f756755
@damianlegawiec
Added StoreHelper#store_link
2083f87
@damianlegawiec
Added mobile Currency / Locale switcher UI
44a8008
@damianlegawiec
Added Spree.showProgressBar
7a69622
@damianlegawiec damianlegawiec merged commit 13bfafb into master Feb 15, 2021
@damianlegawiec damianlegawiec deleted the feature/supported-locale branch February 25, 2021 07:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@btolarz btolarz btolarz approved these changes

@Vegann Vegann Vegann approved these changes

Assignees
No one assigned
Labels
International 🌐
Projects
None yet
Milestone
4.2
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@damianlegawiec @spencerwp @flobby @channainfo @btolarz @Vegann