Fix Duplicate Locales Coming From spree_i18n #10871
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
szymoniwacz
approved these changes
Aug 2, 2021
MatthewKennedy
added a commit
that referenced
this pull request
Aug 3, 2021
Merged
damianlegawiec
pushed a commit
that referenced
this pull request
Aug 3, 2021
* Revert "Fix Duplicate Locales Coming From spree_i18n (#10871)" * Map to_sym so unique works. * Fix test. * Hard code values for result. * Static code expected results.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I18n.available_localesfinds all locales defined in the main Rails app and any installed gems.The behaviour in spree_i18n seems to duplicate this unnecessarily.