Add Indication To Search #10956
Add Indication To Search #10956
Conversation
|
I should imagine this will fail as tests will be looking for less descriptive label name in order and products fields. |
| @@ -1281,6 +1281,7 @@ en: | |||
| price_sack: Price Sack | |||
| process: Process | |||
| product: Product | |||
| product_name: Product Name | |||
There was a problem hiding this comment.
@MatthewKennedy I think we can avoid adding a new translation key by combining product + name translation here :)
There was a problem hiding this comment.
Yeah sure, I'll sort that.
There was a problem hiding this comment.
@damianlegawiec I'll drop that back to just :name if you want?
I was just thinking then as I was concatenating keys, if we build a string from separate translation keys, it might not translate well out of its context of use, if you were to use an auto translation service like translation.io on your app.
Product number => Numéro de produit
product + number => Produit Numéro
What would you prefer? I can concat the keys, drop it back to just :name or leave it with the new translation key?
There was a problem hiding this comment.
Let's leave it as product_name then as it's best for UX 👍
| @@ -1623,7 +1625,6 @@ en: | |||
| customer_support_email_help: "This email is visible to your Store visitors in the Footer section" | |||
| new_order_notifications_email_help: "If you want to receive an email notification every time someone places an Order please provide an email address for that notification to be sent to" | |||
| seo_robots: "Please check <a href='https://developers.google.com/search/reference/robots_meta_tag' target='_blank'>this page for more help</a>" | |||
| store_set_default_button: Set as default | |||
There was a problem hiding this comment.
@MatthewKennedy shouldn't this be kept?
There was a problem hiding this comment.
Thats a duplicate key found:
There was a problem hiding this comment.
YML linter was telling me duplicate key.
Add a little clue to what each search filed is intended to be used for, example:
Search by: Order NumberSearch by: Product NameIssus Fixed in this PR:
en.ymljs-filterable js-quick-search-targetclass causing the ransack search and filters panel to be unusable on stock transfers index.naming.mov