Fix validation errors for Swagger Open API #11228
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Changes preview: |
Add nullable: true to optional fields.
damianlegawiec
approved these changes
Aug 17, 2021
| @@ -5078,7 +5109,7 @@ components: | |||
| included: | |||
| type: array | |||
| items: | |||
| oneOf: | |||
| anyOf: | |||
There was a problem hiding this comment.
@MatthewKennedy this change breaks displaying of States in includes
There was a problem hiding this comment.
I'll look into it...
There was a problem hiding this comment.
@damianlegawiec is this PR code live on: https://api.spreecommerce.org/docs/api-v2/b3A6MzE0Mjc2Nw-get-a-country
There was a problem hiding this comment.
I can't see the states in the live docs either:
Live Docs:
New Version
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
$ref '#...'nested under an object unnecessarily.IdOrPermalinkinto 2 separate references, one dedicatedproductSlugand another fortaxonPermalinkso examples are more relevant to each.