[SD-1377] Display addresses from countries supported in the current store #11271
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Changes preview: |
damianlegawiec
approved these changes
Aug 20, 2021
damianlegawiec
requested changes
Aug 20, 2021
api/spec/requests/spree/api/v2/storefront/account/addresses_spec.rb
Outdated
Show resolved
Hide resolved
v10110
force-pushed
the
feature/SD-1377-API_Account_Addresses_return_addresses_from_countries_from_current_store
branch
from
ba24aae
to
9c3ae0f
Compare
api/spec/requests/spree/api/v2/storefront/account/addresses_spec.rb
Outdated
Show resolved
Hide resolved
api/spec/requests/spree/api/v2/storefront/account/addresses_spec.rb
Outdated
Show resolved
Hide resolved
v10110
force-pushed
the
feature/SD-1377-API_Account_Addresses_return_addresses_from_countries_from_current_store
branch
from
9c3ae0f
to
030a54e
Compare
| context 'when address from countries that are supported in the current store' do | ||
| let!(:country) { create(:country, name: 'France') } | ||
| let!(:zone) { create(:zone, name: 'EU_VAT', countries: [country], kind: 'country') } | ||
| let!(:eu_address) { create(:address, user_id: user.id, country: country) } |
There was a problem hiding this comment.
@v10110 let's also create another address for this user from a country that isn't supported by this store to test if it doesn't show up
api/spec/requests/spree/api/v2/storefront/account/addresses_spec.rb
Outdated
Show resolved
Hide resolved
v10110
force-pushed
the
feature/SD-1377-API_Account_Addresses_return_addresses_from_countries_from_current_store
branch
2 times, most recently
from
33106d0
to
e5e2f37
Compare
v10110
force-pushed
the
feature/SD-1377-API_Account_Addresses_return_addresses_from_countries_from_current_store
branch
from
e5e2f37
to
c62bfd9
Compare
damianlegawiec
approved these changes
Sep 3, 2021
delete-merged-branch
bot
deleted the
feature/SD-1377-API_Account_Addresses_return_addresses_from_countries_from_current_store
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://spark-solutions.atlassian.net/browse/SD-1377