New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[NX-7] Filter taxons by taxonomies' permalinks #11288

Merged

damianlegawiec merged 1 commit into main from nx-7

Aug 26, 2021

Member

pmilewski commented Aug 25, 2021

No description provided.

viezly bot commented Aug 25, 2021 •

edited

Loading

Changes preview:

👀 Review pull request on Viezly

pmilewski force-pushed the nx-7 branch from 7851158 to c0733b5 Compare

August 25, 2021 13:22

damianlegawiec reviewed

View reviewed changes

core/app/finders/spree/taxons/find.rb Outdated Show resolved Hide resolved

pmilewski marked this pull request as ready for review

August 25, 2021 13:45

pmilewski force-pushed the nx-7 branch 3 times, most recently from 1b3a112 to 7725241 Compare

August 25, 2021 14:13

damianlegawiec reviewed

View reviewed changes

api/spec/requests/spree/api/v2/storefront/taxons_spec.rb Show resolved Hide resolved

pmilewski force-pushed the nx-7 branch from 7725241 to 1dafbf9 Compare

August 26, 2021 08:06

damianlegawiec reviewed

View reviewed changes

core/app/finders/spree/taxons/find.rb Outdated Show resolved Hide resolved

pmilewski force-pushed the nx-7 branch 2 times, most recently from e8520fc to 3cb0c41 Compare

August 26, 2021 11:07

damianlegawiec reviewed

View reviewed changes

core/app/finders/spree/taxons/find.rb Outdated Show resolved Hide resolved

damianlegawiec reviewed

View reviewed changes

core/lib/spree/permitted_attributes.rb Outdated Show resolved Hide resolved

Member

damianlegawiec commented Aug 26, 2021

@pmilewski also we need that documented in https://github.com/spree/spree/blob/main/api/docs/v2/storefront/index.yaml

pmilewski force-pushed the nx-7 branch from 3cb0c41 to 95c0bac Compare

August 26, 2021 11:19

damianlegawiec reviewed

View reviewed changes

core/app/finders/spree/taxons/find.rb Outdated Show resolved Hide resolved

pmilewski force-pushed the nx-7 branch from 95c0bac to e02a988 Compare

August 26, 2021 11:24

damianlegawiec reviewed

View reviewed changes

core/app/finders/spree/taxons/find.rb Outdated Show resolved Hide resolved


          [NX-7] Filter taxons by taxonomies' permalinks

e3646a4

pmilewski force-pushed the nx-7 branch from e02a988 to e3646a4 Compare

August 26, 2021 11:50

damianlegawiec approved these changes

View reviewed changes

damianlegawiec merged commit ef2343a into main

delete-merged-branch bot deleted the nx-7 branch

August 26, 2021 12:26

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment