[SD-1461] fix money_methods for ruby version < 2.7 #11373
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Changes preview: Legend: |
|
@KacperMekarski this breaks the ruby 3.0 build, also the title/description is wrong, this works on ruby 2, but only on 2.7+ |
KacperMekarski
changed the title
|
@damianlegawiec tried another approach. |
KacperMekarski
commented
Oct 1, 2021
Comment on lines
+30
to
+32
| amount = args_list.blank? ? send(method_name) : send(method_name, **args_list) | ||
|
|
||
| Spree::Money.new(amount, default_opts.merge(opts).merge(args_list.slice(:currency))) |
There was a problem hiding this comment.
Tried earlier:
Spree::Money.new(send(*[method_name, **args_list].reject(&:blank?)), default_opts.merge(opts).merge(args_list.slice(:currency))) but did not work for ruby 3.*
kgorazd
approved these changes
Oct 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added photo because in Travis we use use newer ruby versions:
https://github.com/spree/spree/blob/main/cli/lib/spree_cli/templates/extension/travis.yml#L17-L19
I considered moving
send(*[method_name, **args_list].reject(&:blank?))toamountprivate method &default_opts.merge(opts).merge(args_list.slice(:currency)tooptionsprivate method, but decided that passing arguments further will make it look too complicated.