Track and record Webhook Events #11434
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Changes preview: Legend: |
Co-authored-by: Damian Legawiec <damian@sparksolutions.co>
Co-authored-by: Damian Legawiec <damian@sparksolutions.co>
| before do | ||
| allow(subject).to receive(:request).and_return(request_double) | ||
| allow(request_double).to receive(:unprocessable_uri?).and_return(true) | ||
| allow(request_double).to( |
There was a problem hiding this comment.
@sebastian-palma rather then testing receiving methods let's test if the record was created and persisted properly
There was a problem hiding this comment.
@damianlegawiec this part isn't testing the subject does receive those method calls, but it's stubbing the respective values for the events creation, which is checked here. As those values depend on the result of performing a HTTP request the whole public interface of MakeRequest has been stubbed through the subject. If we don't do that, we'd be testing the internals of MakeRequest, which has its own examples.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://spark-solutions.atlassian.net/browse/SD-1498