SD-1544 Do not emit webhooks on touch events #11539
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Changes preview: Legend: |
sebastian-palma
approved these changes
Nov 30, 2021
damianlegawiec
approved these changes
Nov 30, 2021
delete-merged-branch
bot
deleted the
feature/ignore-webhooks-on-touch
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@sebastian-palma You were getting a false positive and we still get a false positive. Tested manually, works fine now. There is some issue with ENV['DISABLE_SPREE_WEBHOOKS'] in the specs. Even when I set it to nil it is somehow set to 'true' when it gets to #queue_webhooks_requests!.