Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor Data Feed settings #11877

Merged
merged 1 commit into from
Apr 17, 2023
Merged

Conversation

rafalcymerys
Copy link
Member

This PR introduces some changes to the Data Feeds feature:

  • Renamed DataFeedSetting to DataFeed -
  • Renamed enabled field to active, to keep it consistent with other entities in the database
  • Renamed spree_store_id to store_id, to keep it consistent with other entities in the database, and avoid having to define foreign_key explicitly
  • Renamed uuid to slug
  • Added indexes that will improve the lookup process
  • Changed the uuid/slug generation process - it will be generated every time an empty slug field is provided (even during update). Also, when a custom slug is provided, it will convert it to a value that's safe for URL.

@viezly
Copy link

viezly bot commented Apr 15, 2023

This pull request is split into 3 parts for easier review.
👀 Review pull request on Viezly

Changed files are located in these folders:

  • api/app
  • api/config
  • core/app
  • core/db/migrate
  • core/lib/spree
  • sample/db/samples
  • sample/lib

@rafalcymerys rafalcymerys force-pushed the feature/improve_data_feeds_management branch from 94710d3 to 5cd4810 Compare April 17, 2023 19:39
@rafalcymerys rafalcymerys force-pushed the feature/improve_data_feeds_management branch from 5cd4810 to e03182a Compare April 17, 2023 20:02
@rafalcymerys rafalcymerys merged commit 6f20daa into main Apr 17, 2023
2 checks passed
@delete-merged-branch delete-merged-branch bot deleted the feature/improve_data_feeds_management branch April 17, 2023 20:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants