Use column_fallback plugin for storing default locale's translations in original columns #12040
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Use original column for the translatable fields in the default locale * Remove migrations for transferring and deleting translatable data * Fixes #12019
… using translations * Update API V2 Storefront Products specs
mad-eel
commented
May 15, 2024
| @@ -28,6 +28,10 @@ def set_fallback_locale | |||
| Spree::Locales::SetFallbackLocaleForStore.new.call(store: current_store) | |||
| end | |||
|
|
|||
| def default_locale | |||
There was a problem hiding this comment.
@damianlegawiec Shouldn't we assign the default_locale to I18n.default_locale here: https://github.com/spree/spree/blob/main/core/lib/spree/core/controller_helpers/locale.rb#L21?
If a store has the default_locale set to pl then the current_locale will also be pl (unless picked otherwise). So we're still not using any translations and the I18n.default_locale should also be pl.
mad-eel
force-pushed
the
feature/use-original-columns-for-default-translations
branch
from
d051d79
to
129700b
Compare
damianlegawiec
approved these changes
May 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Scope: