Use Versioncake for API versioning #2209
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks awesome, though I may be a little bias. Let @aantix or I know if you have any comments, questions or issues. |
|
I'm happy to see this merged, @radar do you have any input? |
| @@ -6,6 +6,9 @@ class Engine < Rails::Engine | |||
| isolate_namespace Spree | |||
| engine_name 'spree_api' | |||
|
|
|||
| config.view_versions = [1] | |||
| config.view_version_extraction_strategy = :http_parameter | |||
There was a problem hiding this comment.
This is an invalid value. Valid ones are :query_parameter, :http_header and http_accept_parameter. I assume you mean http_header?
LBRapid
added a commit
that referenced
this pull request
Nov 21, 2012
Fixes #2209 * Unversion zones controller so it can be used with Versioncake for testing purposes * Zones controller using versioncake for versioning * Move other controllers so they make use of Versioncake * Rename all views to make use of Versioncake * No v2 of api yet
|
Added to master and split_core. |
LBRapid
added a commit
that referenced
this pull request
Nov 21, 2012
Fixes #2209 * Unversion zones controller so it can be used with Versioncake for testing purposes * Zones controller using versioncake for versioning * Move other controllers so they make use of Versioncake * Rename all views to make use of Versioncake * No v2 of api yet Conflicts: api/app/controllers/spree/api/v1/base_controller.rb api/app/controllers/spree/api/v1/taxonomies_controller.rb api/app/controllers/spree/api/v1/taxons_controller.rb api/app/views/spree/api/products/index.v1.rabl api/config/routes.rb api/spree_api.gemspec
|
Really like this approach combining with versioncake, will definitely start recommending people to use versioncake in conjunction with RABL |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Getting rid of the v1 namespace and using versioncake to manage different versions of our API.