Improves promotion#products collection method #2363
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
promotion#products should return products from all rules that respond to a products method and not just from the built in PromotionRule::Product class. This should make it easier for developers to use their custom rules to interact with Spree::Promotion
radar
pushed a commit
that referenced
this pull request
Jan 2, 2013
promotion#products should return products from all rules that respond to a products method and not just from the built in PromotionRule::Product class. This should make it easier for developers to use their custom rules to interact with Spree::Promotion Fixes #2363
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
promotion#products should return products from all rules that respond to
a products method and not just from the built in PromotionRule::Product
class.
This should make it easier for developers to use their custom rules to
interact with Spree::Promotion