Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Uses objects instead of symbols to define property and taxon edit forms #326

Closed

Conversation

jeroenj
Copy link

@jeroenj jeroenj commented May 19, 2011

Using symbols instead of objects is causing issues with fields_for which I use in my spree-simple_product_translations extension.

@schof
Copy link
Contributor

schof commented May 24, 2011

@romul Any objection to this?

@romul
Copy link
Member

romul commented May 25, 2011

No, I'm agree with this change.
But I think, even better will be:

form_for([:admin, @property])

than

form_for(@property, :url => object_url, :html => { :method => :put })

@jeroenj
Copy link
Author

jeroenj commented May 25, 2011

Indeed. I was thinking about that too. I guess it should be done for all forms then.

No, I'm fine with this cahange.
I think, even better will be:

form_for([:admin, @Property])

than

form_for(@Property, :url => object_url, :html => { :method => :put })

Reply to this email directly or view it on GitHub:
#326 (comment)

@romul romul closed this in 014d8e1 Jun 8, 2011
jordan-brough pushed a commit to jordan-brough/spree that referenced this pull request Apr 14, 2015
Remove the current_api_user fallback to an unpersisted user.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants