Add #total_on_hand method to Variant model #3427
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| it 'should match quantifier total_on_hand' do | ||
| variant = build(:variant) | ||
| expect(variant.total_on_hand).to eq(Spree::Stock::Quantifier.new(variant).total_on_hand) |
There was a problem hiding this comment.
Not sure how I feel about this calling to Spree::Stock::Quantifier again. I think just a number would be more suitable.
There was a problem hiding this comment.
Yeah, I know, I had the same impression. I didn't want to test more specifics cause there's a bunch of tests for it in the quantifier_spec, so I wasn't sure about the right approach. Any ideas?
There was a problem hiding this comment.
I believe you just need to make sure that the Variant total_on_hand sends the proper message to Quantifier. So I guess one single spec here should be enough.
There was a problem hiding this comment.
Alrighty, makes sense. Thank you @rubenrails + @huoxito.
radar
pushed a commit
that referenced
this pull request
Jul 26, 2013
anthonycreates
pushed a commit
to anthonycreates/spree
that referenced
this pull request
Jul 31, 2013
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We already have that for Product, but there's no way of getting the total_on_hand for a given variant. This commit fixes that.
cc @radar