Don't override accessor if method has attr as column #4012
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Say users want to add a `name` column in spree_variants. They can't make use of that attr on a variant instance because Spree would always delegate that method to a product. Now it would only delegate if the model doesn't have that column. That would be all cases in a default scenario. Possible bad side effects: we're touching the database one more time when booting the spree engine. That's another issue for heroku users right now.
| @@ -37,6 +37,8 @@ def delegate_belongs_to(association, *attrs) | |||
| attrs = get_association_column_names(association) if attrs.empty? | |||
| attrs.concat get_association_column_names(association) if attrs.delete :defaults | |||
| attrs.each do |attr| | |||
| next if table_exists? && column_names.include?(attr.to_s) | |||
There was a problem hiding this comment.
What about attribute_method? instead of this? I think that just checks to see if the attribute method is defined rather than hitting the database. Might do the trick?
|
I don't understand what problem this is fixing. When I add a Steps to reproduce, please! |
|
Oops, my mistake. I had merged this PR earlier into my branch. I've used |
huoxito
added a commit
that referenced
this pull request
Nov 25, 2013
Say users want to add a `name` column in spree_variants. They can't make use of that attr on a variant instance because Spree would always delegate that method to a product. Now it would only delegate if the model doesn't have that column. That would be all cases in a default scenario. Fixes #4012
huoxito
added a commit
that referenced
this pull request
Nov 25, 2013
Say users want to add a `name` column in spree_variants. They can't make use of that attr on a variant instance because Spree would always delegate that method to a product. Now it would only delegate if the model doesn't have that column. That would be all cases in a default scenario. Fixes #4012
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Say users want to add a
namecolumn in spree_variants. They can't makeuse of that attr on a variant instance because Spree would always
delegate that method to a product.
Now it would only delegate if the model doesn't have that column. That
would be all cases in a default scenario.
Possible bad side effects: we're touching the database one more time
when booting the spree engine. That's another issue for heroku users
right now.
Opening this one as a possible suggestion / fix for that use case. Wanted to hear if there's any other better idea or maybe if the use case itself is a bad idea and we shouldn't allow it at all in Spree core. Not really sure what I think about it yet.