Fix available package shipping methods (for 2-1-stable) #4102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* The previous code would return shipping methods that only applied to one of the shipping categories in the package. IMHO the more correct approach is to return only the shipping methods that are common between all the shipping categories. * The #to_a at the end handles the case where the shipping categories are empty, so that an empty Array is returned rather than nil.
|
Added to 2-1-stable. Thanks! |
radar
pushed a commit
that referenced
this pull request
Dec 17, 2013
radar
pushed a commit
that referenced
this pull request
Dec 17, 2013
radar
pushed a commit
that referenced
this pull request
Dec 17, 2013
* The previous code would return shipping methods that only applied to one of the shipping categories in the package. IMHO the more correct approach is to return only the shipping methods that are common between all the shipping categories. * The #to_a at the end handles the case where the shipping categories are empty, so that an empty Array is returned rather than nil. Related to #4102
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(NOTE: This is related to #4103)
This branch fixes the package shipping methods to only return the shipping methods that are common to all the shipping categories. The current code returns all the shipping methods, even those that may not apply to a product.
Typically this isn't noticeable since
Spree::Stock::Splitter::ShippingCategoryis enabled by default, and splits up the package into separate packages grouped by the shipping category. However, when this is not used then the package can potentially return invalid shipping methods.This also adds a unique constraint to the table used by
Spree::ShippingMethodCategorythat ensures the join record is only recorded once. The migration will also remove any duplicate records before applying the uniqueness constraint.