Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix problem with infinite loop of redirects in API #8976

Merged

Conversation

VygovskySergey
Copy link
Contributor

@VygovskySergey VygovskySergey commented Sep 10, 2018

@VygovskySergey VygovskySergey force-pushed the fix/api_redirect_infinite_loop branch 2 times, most recently from fbf46dc to a0f73b6 Compare September 11, 2018 10:08
@kushniryb
Copy link
Contributor

@damianlegawiec
What's the reason behind redirecting from /products to v1/products?
Do we really need this functionality?
It's not apparent whether you've made a mistake or not due to the redirect and it introduces unnecessary complexity on top of it. Maybe it would be a good idea to remove this piece completely?

@damianlegawiec
Copy link
Member

@kushniryb before Spree 3.1 API wasn't versioned. There's a LOT of integrations out there that rely on the API v1 to be available at https://example.com/api/orders.json - that's why this redirect was introduced.

@bbonislawski
Copy link
Contributor

It's part of versioncake Gem. I think this whole thing should be deprecated(and extracted into separate gem) with Spree 4.x since everyone should use api v2

@damianlegawiec
Copy link
Member

@bbonislawski yep, but until 4.0 we should keep this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants