Add twitter card markup for PDP #9818
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Manage this branch in SquashTest this branch here: https://spark-solutionssd-722-twitter-tqa2g.squash.io |
damianlegawiec
requested changes
Jan 22, 2020
| @@ -181,6 +181,17 @@ def image_source_set(name) | |||
| set.join(', ') | |||
| end | |||
|
|
|||
| def og_image_pdp(product) | |||
There was a problem hiding this comment.
@DevilCoders this tag is already added via #9809
| <% content_for :head do %> | ||
| <meta name="twitter:card" content="summary" /> | ||
| <meta property="og:title" content="<%= @product.name %>" /> | ||
| <meta property="og:description" content="<%= og_description(@product) %>" /> |
There was a problem hiding this comment.
Suggested change
| <meta property="og:description" content="<%= og_description(@product) %>" /> | |
| <meta property="og:description" content="<%= meta_data.description %>" /> |
| @@ -0,0 +1,6 @@ | |||
| <% content_for :head do %> | |||
| <meta name="twitter:card" content="summary" /> | |||
| <meta property="og:title" content="<%= @product.name %>" /> | |||
There was a problem hiding this comment.
Suggested change
| <meta property="og:title" content="<%= @product.name %>" /> | |
| <meta property="og:title" content="<%= title %>" /> |
| <meta name="twitter:card" content="summary" /> | ||
| <meta property="og:title" content="<%= @product.name %>" /> | ||
| <meta property="og:description" content="<%= og_description(@product) %>" /> | ||
| <meta property="og:image" content="<%= og_image_pdp(@product) %>" /> |
There was a problem hiding this comment.
Suggested change
| <meta property="og:image" content="<%= og_image_pdp(@product) %>" /> | |
| <meta property="og:image" content="<%= image_url_path %>" /> |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.