Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

User.anonymous? needed by spree (2.1) #153

Closed
rennerDa opened this issue Jan 13, 2014 · 6 comments
Closed

User.anonymous? needed by spree (2.1) #153

rennerDa opened this issue Jan 13, 2014 · 6 comments

Comments

@rennerDa
Copy link

Hi,

with the following commit you deleted the anonymous functions from the User model.
8156808

But in spree, the user_logged_in.rb file needs one of this methods (Branch 2-1-stable, every 2.1.X Tag).

This is not necessary for the master branch (spree+spree_auth_devise) but for every 2-1-stable or tag release.

@radar
Copy link
Contributor

radar commented Jan 15, 2014

I think if we returned order.user.nil? within the eligible check of that promotion rule then it would work the same way. Do you think so too?

@radar
Copy link
Contributor

radar commented Jan 15, 2014

Sorry, that should've been order.user.present?.

@radar
Copy link
Contributor

radar commented Jan 15, 2014

Please try out radar/spree's master or 2-1-stable branch and let me know if that fixes this issue.

@rennerDa
Copy link
Author

Thanks a lot @radar. I didn't know where to fix it (spree or here). Because of that I didn't create a pull request. Maybe next time :) .

Works as expected :) .

I'll leave this open until you merged your changes to spree/spree.

@radar
Copy link
Contributor

radar commented Jan 16, 2014

Thanks for the confirmation!

On Thu, Jan 16, 2014 at 12:04 AM, Daniel Renner notifications@github.com
wrote:

Thanks a lot @radar. I didn't know where to fix it (spree or here). Because of that I didn't create a pull request. Maybe next time :) .
Works as expected :) .

I'll leave this open until you merged your changes to spree/spree.

Reply to this email directly or view it on GitHub:
#153 (comment)

@rennerDa
Copy link
Author

Merged to spree/spree. Thanks a lot @radar !!!
spree/spree@f7e1ddb

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants