ProductsController decorator should be updated/removed

[newijk]

Spree_auth_devise currently decorates the Spree::ProductsController in a way that breaks the expected behavoir. The decorator does not use the active scope like the original method but instead it basically reimplements the active scope (not DRY). This causes unexpected behavoir when changing the products that the active scope returns (ie decorating it).

Additionally, there appears to be no difference in results between either version of the load_products method: in both cases 404 is returned when the product does not exist or the user is not allowed to see the product.

Imho the method should be either updated to use the active scope or removed entirely.

[radar]

You're right. I'll remove this now.

[radar]

Fixed in all branches. Thank you.