1-3-stable: lots of failures running rspec spec #62
Comments
|
This is due to spree_auth_devise suffering neglect over something like the past 3 months while I worked on maintaining spree/spree. It's always been unacceptable to have any failing tests on this, but now it's bothered me enough that I'm actually fixing it. I've got master passing on radar/spree_auth_devise and I'm working on 1-3-stable and 1-2-stable today. |
|
master and 1-3-stable builds are fixed now. Will look at porting over the changes from 1-3-stable into 1-2-stable now. |
|
WOW! Now I understand why you are a Ruby hero! You are awesome! Good job!! []s! On 27/03/2013, at 21:38, Ryan Bigg notifications@github.com wrote:
|
|
Hi, Ryan! Have you commited your changes to spree/spree_auth_devise already (1) git pull Still getting 20 failures... :( []s, On Thu, Mar 28, 2013 at 6:44 AM, Tiago Motta Jorge tiagomjorge@gmail.comwrote:
|
|
Yes I'm pretty certain I did that. Will check on Tuesday when I am back at work. You can confirm yourself by looking at radar/spree_auth_devise and comparing it with the spree version On Thu, Mar 28, 2013 at 10:25 PM, Tiago Motta Jorge
|
|
Hmmm... You did commit, but the tests are still broken... :( []s, On 28/03/2013, at 19:58, Ryan Bigg notifications@github.com wrote:
|
|
Ryan, Does this broken tests mean that anyone who tries to download and run the 1-3-stable spree + spree_auth_devise will find problems or only that the spree_auth_devise's tests weren't maintained for some time? I'm asking this because I was thinking in updating my Spree installation, but these broken tests kinda scared me out! Regards! |
|
As far as I know the tests are passing: http://bit.ly/ZtcgFg Like I said before, if they are still failing then I will check again on Tuesday when I am back at work. Please be patient until then. On Sat, Mar 30, 2013 at 2:19 AM, Tiago Motta Jorge
|
|
Hi, Ryan! Relax, I'm patient! I'm just trying to help. Unfortunately, written text Analysing the output from your TeamCity CI system, somethings are odd (1) it doesn't seem that it is pulling the code from If you pull the spree_auth_devise from 1-3-stable at github, as is, run Hope I've helped! Best regards! On Fri, Mar 29, 2013 at 10:15 PM, Ryan Bigg notifications@github.comwrote:
|
|
I've fixed this up on 1-3-stable now. It was due to the incompatible version of factory_girl_rails. Please try again. |
|
WOW!! Now everything is passing! Good job!! Regards! On Mon, Apr 1, 2013 at 8:37 PM, Ryan Bigg notifications@github.com wrote:
|
Hi!
I'm studying how to build a gem for spree and cloned the spree_auth_devise do study it. This is what I've done:
(1) cloned the 1-3-stable branch of spree_auth_devise;
(2) executed: bundle install
(3) executed: bundle exec rake test_app
(4) executed: bundle exec rspec spec
For my surprise, I've got a lot of Fs....The complete output is below. Are you aware of that? Isn't something very broken?
Regards!
Tiago.
...........................................FF........................FF...FFFFFFFFFFF...FFFF...F....F
Failures:
Spree::ProductsController allows admins to view non-active products
Failure/Error: spree_get :show, :id => product.to_param
ActiveRecord::AssociationTypeMismatch:
Spree::User(#70150645500200) expected, got RSpec::Mocks::Mock(#70150587211420)
./spec/controllers/spree/products_controller_spec.rb:9:in `block (2 levels) in <top (required)>'
Spree::ProductsController cannot view non-active products
Failure/Error: spree_get :show, :id => product.to_param
ActiveRecord::AssociationTypeMismatch:
Spree::User(#70150645500200) expected, got RSpec::Mocks::Mock(#70150587211420)
./spec/controllers/spree/products_controller_spec.rb:16:in `block (2 levels) in <top (required)>'
Users editing users should let me edit the user email
Failure/Error: page.should have_content("successfully updated!")
expected there to be content "successfully updated!" in "\n Spree Administration: \n Users\n\n Spree.translations = {"date_picker":"yy/mm/dd","abbr_day_names":["Sun","Mon","Tue","Wed","Thu","Fri","Sat"],"add":"Add","are_you_sure_delete":"Are you sure you want to delete this record?","bill_address":"Bill Address","choose_a_customer":"Choose a customer","confirm_delete":"Confirm Deletion","cut":"Cut","destroy":"Destroy","edit":"Edit","loading":"Loading","month_names":["January","February","March","April","May","June","July","August","September","October","November","December"],"more":"More","name":"Name","next":"Next","no_results":"No results","on_hand":"On Hand","paste":"Paste","previous":"Previous","remove":"Remove","rename":"Rename","searching":"Searching","sku":"SKU","type_to_search":"Type to search","taxon_placeholder":"Add a Taxon","value":"Value"}\n\n Spree.routes = {"variants_search":"/admin/variants/search.json","taxon_search":"/admin/taxons/search.json","user_search":"/admin/search/users.json","product_search":"/admin/products/search.json"};\n\n//\n\n \n\n Account updated!\n\n \n \n \n \nLoading...\n \n \n\n \n\n \n \n \nLogged in as: susana@cronamills.uk\n\n \nAccount\n\n \nLogout\n\n \nStore\n\n \n \n \n \n Overview\nOrders\nProducts\nReports\nConfiguration\n\n PromotionsUsers\n\n \n \n \n \n \n \n \n Editing User\n\n \n \n \n Back To Users List\n \n\n \n \n \n \n \n \n\n \n \n \n \n\n \n \n\n General Settings\n\n \n \n \n\n \n \n \n \n \n Email\n \n \n Roles\n \n Admin \n \n \n\n \n \n \n \n Password\n \n \n Password Confirmation\n \n\n\n \n \n Update\n or\n cancel\n\n\n \n \n\n API Access\n\n\n No key\n\n \n \n Generate API key\n \n\n\n\n\n\n\n \n \n\n \n\n \n\n \n\n\n "
./spec/requests/admin/users_spec.rb:56:in `block (3 levels) in <top (required)>'
Users editing users should let me edit the user password
Failure/Error: page.should have_content("successfully updated!")
expected there to be content "successfully updated!" in "\n Spree Administration: \n Users\n\n Spree.translations = {"date_picker":"yy/mm/dd","abbr_day_names":["Sun","Mon","Tue","Wed","Thu","Fri","Sat"],"add":"Add","are_you_sure_delete":"Are you sure you want to delete this record?","bill_address":"Bill Address","choose_a_customer":"Choose a customer","confirm_delete":"Confirm Deletion","cut":"Cut","destroy":"Destroy","edit":"Edit","loading":"Loading","month_names":["January","February","March","April","May","June","July","August","September","October","November","December"],"more":"More","name":"Name","next":"Next","no_results":"No results","on_hand":"On Hand","paste":"Paste","previous":"Previous","remove":"Remove","rename":"Rename","searching":"Searching","sku":"SKU","type_to_search":"Type to search","taxon_placeholder":"Add a Taxon","value":"Value"}\n\n Spree.routes = {"variants_search":"/admin/variants/search.json","taxon_search":"/admin/taxons/search.json","user_search":"/admin/search/users.json","product_search":"/admin/products/search.json"};\n\n//\n\n \n\n Account updated!\n\n \n \n \n \nLoading...\n \n \n\n \n\n \n \n \nLogged in as: kaylah@runolfsson.name\n\n \nAccount\n\n \nLogout\n\n \nStore\n\n \n \n \n \n Overview\nOrders\nProducts\nReports\nConfiguration\n\n PromotionsUsers\n\n \n \n \n \n \n \n \n Editing User\n\n \n \n \n Back To Users List\n \n\n \n \n \n \n \n \n\n \n \n \n \n\n \n \n\n General Settings\n\n \n \n \n\n \n \n \n \n \n Email\n \n \n Roles\n \n Admin \n \n \n\n \n \n \n \n Password\n \n \n Password Confirmation\n \n\n\n \n \n Update\n or\n cancel\n\n\n \n \n\n API Access\n\n\n No key\n\n \n \n Generate API key\n \n\n\n\n\n\n\n \n \n\n \n\n \n\n \n\n\n "
./spec/requests/admin/users_spec.rb:65:in `block (3 levels) in <top (required)>'
Checkout should allow a visitor to checkout as guest, without registration
Failure/Error: shipping_method = create(:shipping_method)
NoMethodError:
undefined method `after_create=' for #Spree::Calculator::FlatRate:0x007f9a6df6a608
./spec/requests/checkout_spec.rb:7:in`block (2 levels) in <top (required)>'
Checkout should associate an uncompleted guest order with user after logging in
Failure/Error: shipping_method = create(:shipping_method)
NoMethodError:
undefined method `after_create=' for #Spree::Calculator::FlatRate:0x007f9a72ff0b40
./spec/requests/checkout_spec.rb:7:in`block (2 levels) in <top (required)>'
Checkout should associate an incomplete guest order with user after successful password reset
Failure/Error: shipping_method = create(:shipping_method)
NoMethodError:
undefined method `after_create=' for #Spree::Calculator::FlatRate:0x007f9a72f17250
./spec/requests/checkout_spec.rb:7:in`block (2 levels) in <top (required)>'
Checkout should allow a user to register during checkout
Failure/Error: shipping_method = create(:shipping_method)
NoMethodError:
undefined method `after_create=' for #Spree::Calculator::FlatRate:0x007f9a6cb80db8
./spec/requests/checkout_spec.rb:7:in`block (2 levels) in <top (required)>'
Checkout the current payment method does not support profiles
Failure/Error: shipping_method = create(:shipping_method)
NoMethodError:
undefined method `after_create=' for #Spree::Calculator::FlatRate:0x007f9a74c1a6b8
./spec/requests/checkout_spec.rb:7:in`block (2 levels) in <top (required)>'
Checkout when no shipping methods have been configured
Failure/Error: shipping_method = create(:shipping_method)
NoMethodError:
undefined method
after_create=' for #<Spree::Calculator::FlatRate:0x007f9a6f37fb48> # ./spec/requests/checkout_spec.rb:7:inblock (2 levels) in <top (required)>'Checkout when no payment methods have been configured
Failure/Error: shipping_method = create(:shipping_method)
NoMethodError:
undefined method
after_create=' for #<Spree::Calculator::FlatRate:0x007f9a72d49b80> # ./spec/requests/checkout_spec.rb:7:inblock (2 levels) in <top (required)>'Checkout user submits an invalid credit card number
Failure/Error: shipping_method = create(:shipping_method)
NoMethodError:
undefined method
after_create=' for #<Spree::Calculator::FlatRate:0x007f9a6a9d0740> # ./spec/requests/checkout_spec.rb:7:inblock (2 levels) in <top (required)>'Checkout completing checkout for a free order, skipping payment step
Failure/Error: shipping_method = create(:shipping_method)
NoMethodError:
undefined method
after_create=' for #<Spree::Calculator::FlatRate:0x007f9a72bdfa10> # ./spec/requests/checkout_spec.rb:7:inblock (2 levels) in <top (required)>'Checkout completing checkout with an invalid address input initially
Failure/Error: shipping_method = create(:shipping_method)
NoMethodError:
undefined method
after_create=' for #<Spree::Calculator::FlatRate:0x007f9a7286c108> # ./spec/requests/checkout_spec.rb:7:inblock (2 levels) in <top (required)>'Checkout changing country to different zone during checkout should reset shipments
Failure/Error: shipping_method = create(:shipping_method)
NoMethodError:
undefined method
after_create=' for #<Spree::Calculator::FlatRate:0x007f9a72fc8b90> # ./spec/requests/checkout_spec.rb:7:inblock (2 levels) in <top (required)>'Reset Password should allow a user to supply an email for the password reset
Failure/Error: click_button "Reset my password"
ArgumentError:
A sender (Return-Path, Sender or From) required to send a message
# ./app/models/spree/user.rb:45:in
send_reset_password_instructions' # ./app/controllers/spree/user_passwords_controller.rb:23:increate'# (eval):2:in
click_button' # ./spec/requests/password_reset_spec.rb:15:inblock (2 levels) in <top (required)>'promotion adjustments provides a promotion for the first order for a new user doesn't blow up the signup page
Failure/Error: shipping_method = create(:shipping_method)
NoMethodError:
undefined method
after_create=' for #<Spree::Calculator::FlatRate:0x007f9a7293b7a0> # ./spec/requests/promotion_adjustment_spec.rb:8:inblock (2 levels) in <top (required)>'promotion adjustments provides a promotion for the first order for a new user with an order correctly applies the adjustment if a user signs up as a real user
Failure/Error: shipping_method = create(:shipping_method)
NoMethodError:
undefined method
after_create=' for #<Spree::Calculator::FlatRate:0x007f9a72db12d0> # ./spec/requests/promotion_adjustment_spec.rb:8:inblock (2 levels) in <top (required)>'promotion adjustments provides a promotion for the first order for a new user without an order signing up, then placing an order
Failure/Error: shipping_method = create(:shipping_method)
NoMethodError:
undefined method
after_create=' for #<Spree::Calculator::FlatRate:0x007f9a74823690> # ./spec/requests/promotion_adjustment_spec.rb:8:inblock (2 levels) in <top (required)>'Sign In should allow a user to access a restricted page after logging in
Failure/Error: page.should have_content("Logged in successfully")
expected there to be content "Logged in successfully" in "\n Spree Administration: \n Overview\n\n Spree.translations = {"date_picker":"yy/mm/dd","abbr_day_names":["Sun","Mon","Tue","Wed","Thu","Fri","Sat"],"add":"Add","are_you_sure_delete":"Are you sure you want to delete this record?","bill_address":"Bill Address","choose_a_customer":"Choose a customer","confirm_delete":"Confirm Deletion","cut":"Cut","destroy":"Destroy","edit":"Edit","loading":"Loading","month_names":["January","February","March","April","May","June","July","August","September","October","November","December"],"more":"More","name":"Name","next":"Next","no_results":"No results","on_hand":"On Hand","paste":"Paste","previous":"Previous","remove":"Remove","rename":"Rename","searching":"Searching","sku":"SKU","type_to_search":"Type to search","taxon_placeholder":"Add a Taxon","value":"Value"}\n\n Spree.routes = {"variants_search":"/admin/variants/search.json","taxon_search":"/admin/taxons/search.json","user_search":"/admin/search/users.json","product_search":"/admin/products/search.json"};\n\n//\n\n \n\n\n \n \n \n \nLoading...\n \n \n\n \n\n \n \n \nLogged in as: admin@person.com\n\n \nAccount\n\n \nLogout\n\n \nStore\n\n \n \n \n \n Overview\nOrders\nProducts\nReports\nConfiguration\n\n PromotionsUsers\n\n \n \n \n \n \n \n \n \n Choose Dashboard Locale: \n \n\n \n \n \n \n \n \n\n \n \n \n \n\n \n \n \n\n \n \n//
# ./spec/requests/sign_in_spec.rb:38:in `block (2 levels) in <top (required)>'
Users admin editing roles
Failure/Error: page.should have_content("User has been successfully updated!")
expected there to be content "User has been successfully updated!" in "\n Spree Administration: \n Users\n\n Spree.translations = {"date_picker":"yy/mm/dd","abbr_day_names":["Sun","Mon","Tue","Wed","Thu","Fri","Sat"],"add":"Add","are_you_sure_delete":"Are you sure you want to delete this record?","bill_address":"Bill Address","choose_a_customer":"Choose a customer","confirm_delete":"Confirm Deletion","cut":"Cut","destroy":"Destroy","edit":"Edit","loading":"Loading","month_names":["January","February","March","April","May","June","July","August","September","October","November","December"],"more":"More","name":"Name","next":"Next","no_results":"No results","on_hand":"On Hand","paste":"Paste","previous":"Previous","remove":"Remove","rename":"Rename","searching":"Searching","sku":"SKU","type_to_search":"Type to search","taxon_placeholder":"Add a Taxon","value":"Value"}\n\n Spree.routes = {"variants_search":"/admin/variants/search.json","taxon_search":"/admin/taxons/search.json","user_search":"/admin/search/users.json","product_search":"/admin/products/search.json"};\n\n//\n\n \n\n Account updated!\n\n \n \n \n \nLoading...\n \n \n\n \n\n \n \n \nLogged in as: admin@person.com\n\n \nAccount\n\n \nLogout\n\n \nStore\n\n \n \n \n \n Overview\nOrders\nProducts\nReports\nConfiguration\n\n PromotionsUsers\n\n \n \n \n \n \n \n \n Editing User\n\n \n \n \n Back To Users List\n \n\n \n \n \n \n \n \n\n \n \n \n \n\n \n \n\n General Settings\n\n \n \n \n\n \n \n \n \n \n Email\n \n \n Roles\n \n User \n \n \n Admin \n \n \n\n \n \n \n \n Password\n \n \n Password Confirmation\n \n\n\n \n \n Update\n or\n cancel\n\n\n \n \n\n API Access\n\n\n No key\n\n \n \n Generate API key\n \n\n\n\n\n\n\n \n \n\n \n\n \n\n \n\n\n "
# ./spec/requests/user_spec.rb:26:in `block (2 levels) in <top (required)>'
Finished in 33.01 seconds
101 examples, 21 failures
Failed examples:
rspec ./spec/controllers/spree/products_controller_spec.rb:6 # Spree::ProductsController allows admins to view non-active products
rspec ./spec/controllers/spree/products_controller_spec.rb:13 # Spree::ProductsController cannot view non-active products
rspec ./spec/requests/admin/users_spec.rb:52 # Users editing users should let me edit the user email
rspec ./spec/requests/admin/users_spec.rb:60 # Users editing users should let me edit the user password
rspec ./spec/requests/checkout_spec.rb:27 # Checkout should allow a visitor to checkout as guest, without registration
rspec ./spec/requests/checkout_spec.rb:53 # Checkout should associate an uncompleted guest order with user after logging in
rspec ./spec/requests/checkout_spec.rb:84 # Checkout should associate an incomplete guest order with user after successful password reset
rspec ./spec/requests/checkout_spec.rb:114 # Checkout should allow a user to register during checkout
rspec ./spec/requests/checkout_spec.rb:142 # Checkout the current payment method does not support profiles
rspec ./spec/requests/checkout_spec.rb:166 # Checkout when no shipping methods have been configured
rspec ./spec/requests/checkout_spec.rb:186 # Checkout when no payment methods have been configured
rspec ./spec/requests/checkout_spec.rb:207 # Checkout user submits an invalid credit card number
rspec ./spec/requests/checkout_spec.rb:232 # Checkout completing checkout for a free order, skipping payment step
rspec ./spec/requests/checkout_spec.rb:254 # Checkout completing checkout with an invalid address input initially
rspec ./spec/requests/checkout_spec.rb:280 # Checkout changing country to different zone during checkout should reset shipments
rspec ./spec/requests/password_reset_spec.rb:10 # Reset Password should allow a user to supply an email for the password reset
rspec ./spec/requests/promotion_adjustment_spec.rb:53 # promotion adjustments provides a promotion for the first order for a new user doesn't blow up the signup page
rspec ./spec/requests/promotion_adjustment_spec.rb:69 # promotion adjustments provides a promotion for the first order for a new user with an order correctly applies the adjustment if a user signs up as a real user
rspec ./spec/requests/promotion_adjustment_spec.rb:84 # promotion adjustments provides a promotion for the first order for a new user without an order signing up, then placing an order
rspec ./spec/requests/sign_in_spec.rb:32 # Sign In should allow a user to access a restricted page after logging in
rspec ./spec/requests/user_spec.rb:23 # Users admin editing roles
The text was updated successfully, but these errors were encountered: