Minor spec changes #119
Merged
Minor spec changes #119
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A few small changes to the specs.
Note that while looking at these issues, I discovered that a recent change in spree_core appears to have caused a regression in the spree_auth_devise gem. There is a failing spec on this gem that appears to be a result of this change to spree_core
In spree_core the created_by_id attribute was added to Spree::Order and is now being used to look up Spree::User.last_incomplete_spree_order. But this attribute is not being set if the user authenticates after the current_order is created. This looks like something that needs to be added to associated_user